search

glyph / python-docstring-mode

Emacs minor-mode for editing Python docstrings.
MIT License
70 stars 22 forks source link

fixes #30 #31

Closed vale981 closed 2 years ago

vale981 commented 2 years ago

credits to https://github.com/shabble

fixes #30

vale981 commented 2 years ago

No clue tbh. I have only copied shabble's code :P. It seems that python.el has to be above 0.28.

timlod commented 2 years ago

@glyph Indeed it should be python.el version dependent. I get the issues on Emacs 27.1, for what it's worth. I've been using this fix, which works. Do you have a setup with python.el 0.28 where you don't see the problem reported in my original issue?

glyph commented 2 years ago

@timlod Interesting. My build of Emacs 27.2 (from https://github.com/d12frosted/homebrew-emacs-plus ) includes a python.el that identifies itself as 0.26.1. How are you installing python.el?

glyph commented 2 years ago

Very confusing. ELPA lists https://elpa.gnu.org/packages/python.html as 0.28 which is an upgraded version, but then points at https://github.com/fgallina/python.el as the website which says the repo is no longer maintained.

glyph commented 2 years ago

I pushed an alternate fix (one that doesn't break on older / stock versions of python.el) in https://github.com/glyph/python-docstring-mode/commit/0dbc133cc9f207a448e59f3849c5e3ca51da7bd6 . Hopefully this addresses everybody's issues!