glyph / txsni

Simple support for running a TLS server with Twisted.
MIT License
25 stars 10 forks source link

Allow for empty pem files. #16

Closed glyph closed 5 years ago

codecov-io commented 7 years ago

Current coverage is 85.63% (diff: 100%)

Merging #16 into master will increase coverage by 0.31%

@@             master        #16   diff @@
==========================================
  Files             8          8          
  Lines           361        369     +8   
  Methods           0          0          
  Messages          0          0          
  Branches         21         21          
==========================================
+ Hits            308        316     +8   
  Misses           41         41          
  Partials         12         12          

Powered by Codecov. Last update 3e9379c...d43575c

markrwilliams commented 5 years ago

Seems good! Merge into master after a merge from master!

glyph commented 5 years ago

Thanks for the review!

codecov-io commented 5 years ago

Codecov Report

Merging #16 into master will increase coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   93.76%   93.87%   +0.11%     
==========================================
  Files           6        6              
  Lines         385      392       +7     
  Branches       28       28              
==========================================
+ Hits          361      368       +7     
  Misses         14       14              
  Partials       10       10
Impacted Files Coverage Δ
txsni/test/test_txsni.py 94.4% <100%> (+0.21%) :arrow_up:
txsni/only_noticed_pypi_pem_after_i_wrote_this.py 87.09% <100%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e934ee...e1705db. Read the comment docs.