search

glyph / txsni

Simple support for running a TLS server with Twisted.
MIT License
25 stars 10 forks source link

Test ALPN and NPN separately. #24

Closed markrwilliams closed 5 years ago

markrwilliams commented 5 years ago

OpenSSL does not support NPN with TLS 1.3 (https://github.com/openssl/openssl/issues/3665) so don't attempt NPN if it's likely TLS 1.3 will be used.

Unblocks #23.

codecov-io commented 5 years ago

Codecov Report

Merging #24 into master will increase coverage by 1.62%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #24      +/-   ##
=========================================
+ Coverage   93.87%   95.5%   +1.62%     
=========================================
  Files           6       6              
  Lines         392     400       +8     
  Branches       28      28              
=========================================
+ Hits          368     382      +14     
+ Misses         14      10       -4     
+ Partials       10       8       -2
Impacted Files Coverage Δ
txsni/test/test_txsni.py 98.22% <100%> (+3.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7d4aa1...197f6a6. Read the comment docs.