search

glyph / txsni

Simple support for running a TLS server with Twisted.
MIT License
25 stars 10 forks source link

raise KeyError("no pem file for " + hostname) unicode issue #27

Open dholth opened 5 years ago

dholth commented 5 years ago

in Python 3

            if isinstance(hostname, bytes):
                hostname = hostname.decode('latin1')
            raise KeyError("no pem file for " + hostname)

Maybe make "DEFAULT" b"DEFAULT" to remove the if

glyph commented 5 years ago

Is this a valid issue? I see the PR that attempted to fix it was closed.

dholth commented 5 years ago

The other pr probably addresses this

On Sun, Aug 4, 2019, at 1:13 PM, Glyph wrote:

Is this a valid issue? I see the PR that attempted to fix it was closed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/glyph/txsni/issues/27?email_source=notifications&email_token=AABSZEXYQE4N5YQH4XO5LZTQC4E4RA5CNFSM4HASUALKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3QFZ5A#issuecomment-518020340, or mute the thread https://github.com/notifications/unsubscribe-auth/AABSZEWCENUYPCBK63Y23U3QC4E4RANCNFSM4HASUALA.