search

glyphr-studio / Glyphr-Studio-Desktop

A desktop client for Glyphr Studio built in electron
Other
437 stars 46 forks source link

WIP: Support for save and save as #24

Closed kethinov closed 6 years ago

kethinov commented 6 years ago

Closes https://github.com/glyphr-studio/Glyphr-Studio-Desktop/issues/21

Closes https://github.com/glyphr-studio/Glyphr-Studio-Desktop/issues/25

Closes https://github.com/glyphr-studio/Glyphr-Studio-Desktop/issues/26

Probably closes https://github.com/glyphr-studio/Glyphr-Studio-Desktop/issues/14

Makes progress on #4

kethinov commented 6 years ago

Depends on https://github.com/glyphr-studio/Glyphr-Studio-1/pull/263

kethinov commented 6 years ago

@mattlag and @Autre31415 this is a super rough implementation so lemme know what sucks and I'll fix it.

One thing I don't like about it already is it only works via keyboard commands (ctrl/cmd+s for save and ctrl/cmd+shift+s for save as). The visual save button is not handled.

Open to ideas for improvements on how it should work.

mattlag commented 6 years ago

I agree, this needs a bit more thought.

  1. Handle it via the (Electron-only) File > Save As option. File menu doesn't exist in the browser version, so could be surfaced / handled separately here.

  2. Treat the save button in the left bar as "Save As" if electron, but if browser then treat as current save experience.

kethinov commented 6 years ago

Okay yeah that all makes sense. I'll push an update with those changes.

Can you publish a new version of the main repo that has my changes to it so we can inherit it in the desktop app?

kethinov commented 6 years ago

All right, pushed up some changes that reflect those additional requirements.

Pretty hacky in how it interacts with that save button, but it seems to work. If we want to clean up the interactions between how electron talks to that save button, I'll need to PR the main project again. Up to you which way you think we should go with it.

kethinov commented 6 years ago

I suppose one more thing I should do on this at least before we merge it is suppress the save/save-as menus on the welcome screen.

kethinov commented 6 years ago

Okay, took care of suppressing the save/save-as menus on the welcome screen.

kethinov commented 6 years ago

@mattlag and @Autre31415 I think I'm done tweaking it now. Give it a spin and let me know if you think this is good now.

Autre31415 commented 6 years ago

@mattlag I've issued a release that includes these changes here. If you think any other changes should be made let us know and we'll put up another PR.