search

gma / nesta

File Based CMS and Static Site Generator
http://nestacms.com
MIT License
902 stars 121 forks source link

Fixed the generated gemspec file to use 'gem' object passed to the block (instead of 's', which doesn't exist) #106

Closed ms closed 12 years ago

ms commented 12 years ago

In nesta's .gemspec, we use 's', but bundle gem generates a .gemspec file using a variable 'gem'.

gma commented 12 years ago

Thanks. Bundler 1.1 I see…

gma commented 12 years ago

We need to be a bit more careful with these…

http://travis-ci.org/#!/gma/nesta/jobs/998668

ms commented 12 years ago

I swear I'll start using spec more regularly! Now is there any possibility an old bundle would generate "s."?

gma commented 12 years ago

Sadly, yes. 1.0.27 did it for me yesterday.

ms commented 12 years ago

The revision that changed it is carlhuda/bundler@86dd35b516b4a017db8d50eb71796bcb101e1d2c

jmervine commented 11 years ago

I see that this has been fixed in the code, but the latest gem still doesn't appear to have it. 

$ gem search nesta -r | grep "^nesta "
nesta (0.9.13)

$ bundle | nesta grep
Using nesta (0.9.13) 

$ bundle exec nesta plugin:create foobar
      create  nesta-plugin-foobar/Gemfile
      create  nesta-plugin-foobar/Rakefile
      create  nesta-plugin-foobar/LICENSE.txt
      create  nesta-plugin-foobar/README.md
      create  nesta-plugin-foobar/.gitignore
      create  nesta-plugin-foobar/nesta-plugin-foobar.gemspec
      create  nesta-plugin-foobar/lib/nesta-plugin-foobar.rb
      create  nesta-plugin-foobar/lib/nesta-plugin-foobar/version.rb

$ ack "s.add_" ./nesta-plugin-foobar/nesta-plugin-foobar.gemspec
  s.add_dependency("nesta", ">= 0.9.11")
  s.add_development_dependency("rake")

Should this be considered open until it's released?

gma commented 11 years ago

I really need to get 0.10.0 out. Sorry.

I'd rather not re-open bugs until they've been released though; GitHub doesn't seem very well suited to that (i.e. there's no "Implemented but not released" status).