search

gma / nesta

File Based CMS and Static Site Generator
http://nestacms.com
MIT License
902 stars 121 forks source link

Document title always shows title of home page #108

Closed chadoh closed 12 years ago

chadoh commented 12 years ago

It weirds me out to see things like "Documentation - Home" in my tab. I think it would make a lot more sense to see "Documentation - Nesta".

Is this being done for SEO reasons? (If so, why does SEO involve not keeping your brand name in the title?)

I can override it in my own theme, but I'd rather patch Nesta and "fix" this, if you deem it something that requires fixing.

gma commented 12 years ago

Hi Chad. Cheers for pointing that out. The title is made from a combination of the current page's heading, and the parent page's heading. For nestacms.com, the home page had a heading of "Home", so it was a problem with the site, not Nesta itself. Fixed now, cheers.

chadoh commented 12 years ago

Yeah, I saw how it was made, but that's what seems wrong to me. It seems wrong on nestacms.com, and it seems wrong on chadoh.com (I changed the layout.haml file for now to make it work the way I want). It seems wrong that when you're on a nested page on nestacms.com right now, it shows up as "Configuration - Documentation". It seems like it should still be "Configuration - Nesta" to me. And I think it looked much more natural to have "Home" in the main nav instead of "Nesta".

So I'm not sure when it makes sense to use the parent page instead of the site title. To me it seems the default should be the site title, and let people customize it if they want to. But again, I'm no good at SEO and you are, so let me know if this is an SEO thing.

(Also, I think a pipe is a better separater than a dash, but that's as pointless an argument as emacs vs vim. :smile: )

gma commented 12 years ago

On 23 Apr 2012, at 12:58, Chad Ostrowski wrote:

It seems wrong that when you're on a nested page on nestacms.com right now, it shows up as "Configuration - Documentation". It seems like it should still be "Configuration - Nesta" to me. And I think it looked much more natural to have "Home" in the main nav instead of "Nesta".

I see your point. Really, it should say "Configuring Nesta", or something similar. I may just change the title method so that it returns the page heading, without adding anything next to a separator. That's the best SEO option.

The existing title behaviour predates the title metadata; anybody who really wanted a special title with separators in could just set it on a per-page basis with the title metadata.

Dropping the suffix would also make it easier to pipe /articles.xml into an automated tweeting service (like Buffer), via ifttt.com, without tweeting something nonsensical like this:

Blogged: Title of page - Title of parent page - http://url.of.page

Hmmm, that might be the best option...

gma commented 12 years ago

@chadoh Not sure if you'll have had an automatic email from GitHub; I dropped the context from the title.

chadoh commented 12 years ago

Great! Glad to see it's been simplified.