search

gma / nesta

File Based CMS and Static Site Generator
http://nestacms.com
MIT License
902 stars 121 forks source link

Pass all options down to submenus #120

Closed gadomski closed 11 years ago

gadomski commented 11 years ago

I'd like the :class option to be passed down to submenus as well, for use in Bootstrap. I'm not sure if this is always desirable behavior, or if this is the right way to go about the change.. If not, we could add another option (clunky) to control if the class options is passed down to submenus? Thoughts?

gma commented 11 years ago

I'm wondering if a nesta-bootstrap plugin, that tweaks the behaviour of the defaults a bit, would be a good idea.

I don't think there'd be a big problem with this change if it had always been this way, but there's scope for changing from ul.menu ul to ul.menu ul.menu to mess up the display of existing sites.

gadomski commented 11 years ago

I definitely see how this could be a breaking change. Per this comment on #118 I'll look at moving this to a plugin.

gadomski commented 11 years ago

Closing as wontfix, I'll put this in the bootstrap-helper plugin as discussed in #118.