Closed pengwynn closed 11 years ago
Cheers Wynn, this'll be a big help with lowering the barrier to merging other PRs.
Long term I'm planning on moving to minitest (there's a branch where I've made a start), but I've been doing that for ages and it's not imminent, so this is great.
I'll take a look at merging soon... :-)
On 8 Jan 2013, at 15:56, Wynn Netherland notifications@github.com wrote:
A first pass to get Nesta on RSpec 2.0. This commit
Upgrades Rspec Moves spec.opts to .rspec Updates Rake tasks for Rspec Replaces defunct have_tag matchers with Webrat have_selector and have_xpath Implements the specs marked pending because Nokogiri s HTML5 more than Hpricot. I haven't changed the syntax yet, but I'd recommend we update the specs for the new expect-style.
You can merge this Pull Request by running
git pull https://github.com/pengwynn/nesta rspec-2-0 Or view, comment on, or merge it at:
https://github.com/gma/nesta/pull/123
Commit Summary
Upgrade to RSpec 2.0 File Changes
A .rspec (0) M Gemfile.lock (22) M Rakefile (7) M nesta.gemspec (7) M spec/atom_spec.rb (87) M spec/model_factory.rb (14) M spec/models_spec.rb (128) M spec/overrides_spec.rb (38) M spec/page_spec.rb (160) M spec/sitemap_spec.rb (64) M spec/spec_helper.rb (22) Patch Links:
https://github.com/gma/nesta/pull/123.patch https://github.com/gma/nesta/pull/123.diff
Graham Ashton Founder, The Agile Planner http://theagileplanner.com | @agileplanner | @grahamashton
Merged.
A first pass to get Nesta on RSpec 2.0. This commit
have_tag
matchers with Webrathave_selector
andhave_xpath
I haven't changed the syntax yet, but I'd recommend we update the specs for the new
expect
-style.