search

gma / nesta

File Based CMS and Static Site Generator
http://nestacms.com
MIT License
902 stars 121 forks source link

updated haml dependency to 4.0 #131

Closed sergey-alekseev closed 11 years ago

sergey-alekseev commented 11 years ago

Haml 4.0 has been released! http://blog.haml.info/post/42998475354/haml-4-0-has-been-released

gma commented 11 years ago

Thanks for the patch.

I haven't tried it yet, but I doubt this'll get merged quickly as there will be plenty of knock on effects, upgrade docs to write, etc.

sergey-alekseev commented 11 years ago

I assume this is backward compatible, just give it a try :)

gma commented 11 years ago

It isn't - just read the release notes.

On 14 Feb 2013, at 23:04, Sergey Alekseev notifications@github.com wrote:

I assume it will be backward compatible, just give it a try :)

— Reply to this email directly or view it on GitHub.

gma commented 11 years ago

Right, now I'm at a proper keyboard I can say a bit more about why I'm not keen on doing this now.

Nesta is often loaded in the same Gemfile as a Rails project, so (given the backwards compatibility issues that are talked about in the Haml release notes) requiring 4.0 could prevent some people from being able to use the next release of Nesta due to versioning conflicts.

There's a lot of behaviour to be tested (in real apps, both with and without Rails 3 and 4) before I'll know what the implications of bumping Haml to 4 are, so this commit won't hit the master branch until I've checked that out.

It probably won't make the next release of Nesta either; there are a bunch of features queued up for the next release that I want to make available to people without them needing to worry about the Haml change/version conflicts at the same time. Another release with Haml 4 might follow shortly after it, but that will come down to how significant any issues appear to be in practice, what people generally use with Rails at that point, etc.

The backwards incompatibility changes would also need documenting in the release notes when a new version of the Nesta gem is released (otherwise Nesta will appear broken to people who've been using the maruku filter, for example). That's just not a priority right now (while tidying a couple of other things up and getting the next release out is).

So while this will clearly happen, I'm going to close the issue for now to keep the list of open issues tidy.

nathany commented 11 years ago

My not just relax the dependency to > 3.1? That avoids any possible conflicts with Rails users, as bundler will sort it out based on if they include a more constrained version of Haml.

If people can't easily tweak Nesta to what dependencies they want, you'll just end up with a bunch of forks.

gma commented 11 years ago

I probably will do that, but not until I've got time for testing everything.

On 27 Feb 2013, at 03:43, Nathan Youngman notifications@github.com wrote:

My not just relax the dependency to > 3.1? That avoids any possible conflicts with Rails users, as bundler will sort it out based on if they include a more constrained version of Haml.

If people can't easily tweak Nesta to what dependencies they want, you'll just end up with a bunch of forks.

— Reply to this email directly or view it on GitHub.

Graham Ashton Founder, Agile Planner https://www.agileplannerapp.com | @agileplanner | @grahamashton