search

gma / nesta

File Based CMS and Static Site Generator
http://nestacms.com
MIT License
902 stars 121 forks source link

Use Builder for XML responses #138

Closed datenimperator closed 11 years ago

datenimperator commented 11 years ago

IMO using HAML for XML-based responses is ugly. Additionally a theme author needs to watch out to not accidentally overwrite those templates. So I rebuilt the two responses using Builder. I've successfully tested it under MRI 1.9.3. Since mr-sparkle doesn't build using MRI 1.8.7 I guess there's no need to run the specs with that outdated Ruby?

datenimperator commented 11 years ago

dafuq My branch is only meant to contain the very last two commits from this list. The rest isnt supposed to be pulled. Can you clean/restrict that?

gma commented 11 years ago

Thanks for the patch.

I agree that it's harder for theme authors who are typing cp .../*.haml to avoid the templates, but maybe we need a better way of starting a new theme from the default to solve that cleanly? (I'm thinking a nesta theme:clone command [that might not be the best name], that knows not to copy the sitemap and atom feed files into a new theme folder)

I don't think there's anything wrong with generating XML with Haml though; it's designed to do it (e.g. XHTML). I started out with builder, but once I twigged that Haml could do it I binned builder to simplify third party dependencies and reduce the API you need to understand. I don't think either of us is necessarily "right" here (we're optimising for slightly different things), but I've already gone the opposite way!

Try this: git log -3 45d1e9