search

gma / nesta

File Based CMS and Static Site Generator
http://nestacms.com
MIT License
902 stars 120 forks source link

Update from sass to sassc #179

Closed etc closed 4 years ago

etc commented 4 years ago

Ruby Sass has reached end-of-life and should no longer be used.

More information is available here: https://sass-lang.com/blog/ruby-sass-is-unsupported

This update simply switches from the sass gem to the sassc gem, as recommended in that post.

gma commented 4 years ago

Hi Brad. Cheers for sending this in; I hadn't realised the Ruby version was deprecated!

I noticed that the Travis build was failing for your PR, and that there were more gems updated in your commit that switched to sassc than I expected, so I re-did the upgrade locally and made sure Bundler only applied conservative updates. The patch is now on master.

To get the CI build passing I've had to configure Travis to specifically install Bundler 1.x too (Nesta still supports Ruby 2.2, which doesn't work with Bunder 2.x).

I credited you with the patch in CHANGES.

etc commented 4 years ago

Brilliant, thanks for sorting that out—I realised I had screwed up by applying those other changes but wasn't sure how to correct for it.

On Mon, 30 Mar 2020 at 04:35, Graham Ashton notifications@github.com wrote:

Hi Brad. Cheers for sending this in; I hadn't realised the Ruby version was deprecated!

I noticed that the Travis build was failing for your PR, and that there were more gems updated in your commit that switched to sassc than I expected, so I re-did the upgrade locally and made sure Bundler only applied conservative updates. The patch is now on master.

To get the CI build passing I've had to configure Travis to specifically install Bundler 1.x too (Nesta still supports Ruby 2.2, which doesn't work with Bunder 2.x).

I credited you with the patch in CHANGES.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gma/nesta/pull/179#issuecomment-605860866, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFDE3CHADPLNQ4N7SY47DRKBKVDANCNFSM4LSHGQIA .