Migrate tests to test/unit

[gma]

I much prefer minitest to Rspec, primarily because upgrading to the latest Rspec API isn't something I'm prepared to spend my free time doing.

We also need to split unit tests from integration tests, and separate the integration tests into those that can be expected to pass for any theme, and those that are specific to the default theme.

Tasks

• [x] Write rake tasks to execute the tests (rake test:unit, rake test:integration, rake test)
• [x] Port spec files to minitest:
  • [x] atom_spec.rb
  • [x] commands/*_spec.rb
  • [x] config_spec.rb
  • [x] models_spec.rb
  • [x] overrides_spec.rb
  • [x] page_spec.rb
  • [x] path_spec.rb
  • [x] plugin_spec.rb
  • [x] sitemap_spec.rb
• [x] Remove rspec and test/unit gems.
• [x] Remove methods used only by Rspec from new ModelFactory.
• [x] Refactor ModelFactory:
  • [x] Replace create_* methods with simple create(:type...) approach.
  • [x] Add auto-incrementing sequence to file paths (get it working on all writers).
  • [x] Go through each test file, removing unnecessarily specified paths.
• [x] Consider whether to break tests' dependency on contents of default theme.

  Stack

After merging branch to master:

• [x] Rename @@page_cache to @@model_cache.
• [x] Get rid of/refactor delete_page in model factory.

[jcoffin]

For what its worth, you've got my vote for minitest. I would happily help. This is a bit tangential, but it might also be a good idea to move some of the tests to separate files; 500+ lines of nested describe blocks get confusing.

[gma]

On 15 Apr 2011, at 19:43, jcoffin wrote:

For what its worth, you've got my vote for minitest. I would happily help. This is a bit tangential, but it might also be a good idea to move some of the tests to separate files; 500+ lines of nested describe blocks get confusing.

I agree; it's getting too unwieldy as it stands. The time to decide what to do there is after the theme specific tests have been split out into a separate folder.

I need to get it started at some point, and I'm keen to do that before any more really significant features go in. I also want to improve the API of the factory methods as part of this refactoring; they've gotten into a bit of a mess.

Thanks for the offer of help. I'll get in touch when the time comes if it's takes me more than a few hours to port them over.