gma / nesta

File Based CMS and Static Site Generator
http://nestacms.com
MIT License
902 stars 121 forks source link

no ending - in title when parent.heading.nil? #37

Closed lindblom closed 13 years ago

lindblom commented 13 years ago

First I would like to apologize for doing two changes in my last commit and not writing about them both in the commit message. I had forgotten about the first change when i commited.

I just wanted you to pull the change i made to the models.rb so the title doesn't end with a - when a parent exists but the parent.heading is nil.

I know that im a mess, but im new to git and github so please bare with me ;)

lindblom commented 13 years ago

I didn't want to send you the changed home to hem request, it just piggybacked. (as i said, im new)

Im working on a version of nesta to be used for my sites/blogs in swedish, if you'll add support for localization, ill happily translate to swedish for you :)

gma commented 13 years ago

Hi. Thanks for these. I've not had a chance to look at the code yet, but I'll respond/merge, hopefully later today.

To get heroku to load your version of the gem you'd have to release the gem publicly. Please don't; it would cause confusion in the community. The approach to take is to monkey patch the code you want to change in app.rb. If you're not sure what I mean by that I can help you get it sorted (it'd best to email the list with an example of what you want to do).

lindblom commented 13 years ago

I haven't made a gem, just set gem 'nesta', :git => "git://github.com/lindblom/nesta.git" in the gemfile and changed the version in my fork. That made heroku load it, that couldn't mess things up, could it?

The changes i've made to make it work better for me is in the following commits: changed the way titles were produced (personal preference) and changed home to hem

As i said, i dont want to merge all the changes i've made, just one, i didn't know that i had to send the whole thing. In future ill make a new fork and just do the changes and then ask for a pull. That must be the easiest way.

Well, ill go read up on monkey patching now, and hopefully be back on the original gem soon :)

Thanks.

lindblom commented 13 years ago

Now i think everything is back to where i want it to be, where you should just be able to merge and get the change that i wanted to send. :)

I moved my site-specific code to the app.rb in the theme directory, works like a charm, you are one clever dude! :D

gma commented 13 years ago

Cool, thanks. This patch is on my todo list for tomorrow (paid work can really get in the way!).

gma commented 13 years ago

Merged, cheers. See:

https://github.com/gma/nesta/commit/c5103cc526f8a28d4426089f6f5973e7f0435f54

and:

http://nestacms.com/credits