Tab completion isn't quite right for directories

jmoses commented 12 years ago

When I tab complete a directory, it doesn't add a "/" to the end, it adds a sapce, which isn't correct.

tconsole> te[tab]

gives me

tconsole> ./test [cursor here]

where I would expect

tconsole> ./test/[cursor here]

batasrki commented 12 years ago

What's the significance? Does it mess up your test run?

jmoses commented 12 years ago

No, but affects the ability to easily tab through multiple directories. te[tab]un[tab]model[tab] doesn't seem to be possible.

Sent from my iPhone

On Jan 24, 2012, at 12:05 PM, Srdjan Pejicreply@reply.github.com wrote:

What's the significance? Does it mess up your test run?

Reply to this email directly or view it on GitHub: https://github.com/commondream/tconsole/issues/22#issuecomment-3635986

batasrki commented 12 years ago

It messes with your workflow, in other words. Ok, we'll take a look at it.

On Tuesday, January 24, 2012, Jon Moses < reply@reply.github.com> wrote:

No, but affects the ability to easily tab through multiple directories. te[tab]un[tab]model[tab] doesn't seem to be possible.

Sent from my iPhone

On Jan 24, 2012, at 12:05 PM, Srdjan Pejicreply@reply.github.com wrote:

What's the significance? Does it mess up your test run?

Reply to this email directly or view it on GitHub: https://github.com/commondream/tconsole/issues/22#issuecomment-3635986

Reply to this email directly or view it on GitHub: https://github.com/commondream/tconsole/issues/22#issuecomment-3638381

jmoses commented 12 years ago

Yeah, just my workflow, and it's only a few extra keys, but still minorly annoying.

I looked at it, and I don't even see where readline is getting it's list of things to tab-complete, unless it defaults to directories. I may take a stab at it in in a fork and submit a PR, if I get an hour in the next couple days.

batasrki commented 12 years ago

What version of tconsole are you using? I just tried it out with the 1.0.0 release on a test app and found it not doing the behaviour you saw. Also, what shell are you using?

jmoses commented 12 years ago

1.0.0 and I'm using bash on osx. Could it be that it's because the directories i'm using are command names?

Sent from my iPhone

On Jan 24, 2012, at 9:03 PM, Srdjan Pejicreply@reply.github.com wrote:

What version of tconsole are you using? I just tried it out with the 1.0.0 release on a test app and found it not doing the behaviour you saw. Also, what shell are you using?

Reply to this email directly or view it on GitHub: https://github.com/commondream/tconsole/issues/22#issuecomment-3644553

batasrki commented 12 years ago

Do you mind doing a screenshot like the one I've linked here? https://skitch.com/srdjanpejic/g5ujc/1-thanks-for-flying-vim

As you can see, I'm using minitest in my app and I've used the directories that were initially created by rails. I'm also using bash, through iTerm2, on OSX.

jmoses commented 12 years ago

Sure.

https://img.skitch.com/20120125-gsxyx986gbygytp7g8jx67fbya.jpg

On Tuesday, January 24, 2012 at 9:18 PM, Srdjan Pejic wrote:

Do you mind doing a screenshot like the one I've linked here? https://skitch.com/srdjanpejic/g5ujc/1-thanks-for-flying-vim

As you can see, I'm using minitest in my app and I've used the directories that were initially created by rails. I'm also using bash, through iTerm2, on OSX.

Reply to this email directly or view it on GitHub: https://github.com/commondream/tconsole/issues/22#issuecomment-3644694

batasrki commented 12 years ago

OK, so you seem to have RSpec tests, as well as regular Minitest tests. I'll see if that affects anything or not. It feels like a shell issue, though. I tried both through the Terminal.app and iTerm2 without success.

I'll keep trying to hunt it down.

jmoses commented 12 years ago

Stupid keyboard shortcuts. Yeah, if you need anything else from me, let me know. I'm running under bundler with gemsets via RVM.

Gems included by the bundle:

RubyInline (3.8.6)
Saikuro (1.1.0)
ZenTest (4.4.2)
aasm (2.2.0)
abstract (1.0.0)
actionmailer (3.0.4)
actionpack (3.0.4)
active_reload (0.1.0)
activemodel (3.0.4)
activerecord (3.0.4)
activeresource (3.0.4)
activesupport (3.0.4)
acts_as_list (0.1.4)
addressable (2.2.4)
airbrake (3.0.4)
archive-tar-minitar (0.5.2)
arel (2.0.8)
arrayfields (4.7.4)
awesome_print (0.4.0)
aws-s3 (0.6.2)
bcrypt-ruby (2.1.4)
broach (0.2.1)
builder (2.1.2)
bundler (1.1.rc)
cap-ext-webistrano (0.1.4)
capistrano (2.5.19)
capistrano-ext (1.2.1)
capybara (1.1.1)
capybara-screenshot (0.1.0)
capybara-webkit (0.7.2)
childprocess (0.2.2)
chronic (0.2.3)
churn (0.0.13)
cmdparse (2.0.3)
colored (1.2)
columnize (0.3.2)
configuration (1.2.0)
controller_filter_logging (0.0.8)
crack (0.1.8)
css_parser (1.1.9)
cucumber (1.1.2)
cucumber-rails (1.2.0)
daemons (1.1.0)
database_cleaner (0.6.0)
diff-lcs (1.1.3)
eisenhower (0.0.3)
erubis (2.6.6)
escape (0.0.4)
ezcrypto (0.7.2)
factory_girl (1.3.3)
factory_girl_rails (1.0.1)
faker (0.9.5)
fattr (2.2.0)
feature_flipper (1.3.0)
ffi (1.0.11)
flay (1.4.2)
flog (2.5.1)
foreman (0.26.0)
gelf (1.1.3)
gherkin (2.6.4)
grit (2.4.1)
haml (3.0.25)
has_scope (0.5.1)
headless (0.1.0)
highline (1.6.1)
hirb (0.3.6)
hoe (2.8.0)
httparty (0.7.8)
i18n (0.6.0)
image_science (1.3.2.1.Asynchrony 8c755b0)
inherited_resources (1.3.0)
interactive_editor (0.0.8)
jslint_on_rails (1.0.6)
json (1.4.6)
json_pure (1.6.1)
kaminari (0.12.4)
launchy (0.3.7)
linecache19 (0.5.12)
macaddr (1.0.0)
mail (2.2.15)
main (4.4.0)
map_by_method (0.8.3)
mechanize (1.0.0)
memcache-client (1.8.5)
meta_where (1.0.1)
metric_fu (2.0.1)
mime-types (1.17.2)
minitest (2.0.2)
minitest-rg (0.4)
mixpanel (0.8.1)
mocha (0.9.10)
mock-aws-s3 (0.6.0)
mr_reporto (0.0.1)
multi_json (1.0.4)
mysql2 (0.2.11)
nap (0.4)
net-scp (1.0.4)
net-sftp (2.0.5)
net-ssh (2.1.0)
net-ssh-gateway (1.0.1)
newrelic_rpm (3.3.1.beta2)
nokogiri (1.5.0)
oauth (0.4.4)
open4 (1.3.0)
packet (0.1.15)
paperclip (2.3.8)
parallel (0.5.9)
parallel_tests (0.6.7)
perftools.rb (0.5.6)
polyglot (0.3.1)
pr_geohash (1.0.0)
rabl (0.3.0)
rack (1.2.4)
rack-mount (0.6.13)
rack-perftools_profiler (0.5.0 b7467c8)
rack-test (0.5.7)
rails (3.0.4)
rails3_acts_as_paranoid (0.0.4)
rails_best_practices (0.9.0)
railties (3.0.4)
rake (0.8.7)
rcov (0.9.9)
redis (2.0.1)
redis-namespace (1.0.3)
redisk (0.2.2)
reek (1.2.8)
responders (0.6.4)
resque (1.19.0)
resque-scheduler (2.0.0.f fc7aebf)
resque-status (0.2.1)
resque_unit (0.3.3)
rest-client (1.6.1)
roodi (2.1.0)
rpm_contrib (2.1.6)
rsolr (0.12.1)
ruby-debug-base19 (0.11.25)
ruby-debug19 (0.11.6)
ruby-prof (0.11.0 aece113)
ruby-progressbar (0.0.10)
ruby2ruby (1.2.5)
ruby_core_source (0.1.5)
ruby_parser (2.0.6)
rubyzip (0.9.4)
rufus-scheduler (2.0.14)
sauce (0.17.6)
savon (0.7.9)
sax-machine (0.1.0)
scrubber (0.0.3 f9c229e)
selenium-webdriver (2.12.2)
sexp_processor (3.0.9)
shoulda (2.11.3)
simple-useragent (1.0.0)
simple_form (1.5.2)
simple_lockfile (1.1.1)
simplecov (0.4.2)
simplecov-html (0.4.5)
sinatra (1.2.7)
spoon (0.0.1)
spork (0.9.0.rc7)
spork-testunit (0.0.5)
sunspot (1.2.rc4)
sunspot_rails (1.2.rc4)
syslogger (1.2.0)
tconsole (1.0.0)
term-ansicolor (1.0.6)
thor (0.14.6)
tilt (1.3.3)
timecop (0.3.5)
treetop (1.4.9)
trollop (1.16.2)
twilio (3.0.1)
twitter_oauth (0.4.3)
tzinfo (0.3.31)
uuid (2.3.2)
vcr (1.5.1)
vegas (0.1.8)
webmock (1.6.2)
webrat (0.7.3)
will_paginate (3.0.pre2)
xml-simple (1.0.13)
xpath (0.1.4 a7eafab)

ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-darwin11.2.0]

nalanj commented 12 years ago

I just made some tweaks to the autocompletion code that should get things more like you expect. You can install the latest prerelease with 'gem install tconsole --pre'

Thanks for reporting this! It's definitely a big deal to me to make sure that the testing workflow is as smooth as possible.

jmoses commented 12 years ago

That indeed fixes my issue, awesome. Thanks.

gma / tconsole

Tab completion isn't quite right for directories #22