search

gmacario / easy-build

Collection of Dockerfiles for building embedded software distributions
Mozilla Public License 2.0
154 stars 83 forks source link

Add yocto build support for Renesas rcar-gen3 #257

Closed DextersHub closed 7 years ago

DextersHub commented 7 years ago

The script file attached generates a build image for h3ulcb board

Source: http://elinux.org/R-Car/Boards/Yocto-Gen3#Running_Yocto_image

gmacario commented 7 years ago

Thanks @DextersHub for your PR, however I would refrain from adding yet another Docker image to this repository as I personally do not currently own a Renesas rcar-gen3 to test it with.

By the way, Isn't there any chance that this can be achieved by using Docker image gmacario/build-yocto instead?

gunnarx commented 7 years ago

@DextersHub - it's not my repo but just as a tip - you could squash the two commits together before you send it. The second commit that does "remove trivial patch" is undoing part of what the first commit does. So from the receiving project's perspective (this one) it would probably be better if it was not there in the first place. In other words, squash them together and provide only the pristine and perfect change request. A single commit is probably enough here.

Agree with @gmacario - regardless if this gets merged or you only keep it locally, if you build incrementally on gmacario/build-yocto you can easier keep up to date with fixes made to that base image, and there is less duplication of apt-get install commands and such.

DextersHub commented 7 years ago

@gmacario I saw two other yocto boards in your repo and thought that your idea was to treat the boards individually. Instead of a common one.