search

gmag11 / ESPNtpClient

High accuracy NTP library for ESP32 and ESP8266
MIT License
118 stars 25 forks source link

Side-Efect - WiFi.reconnect #19

Closed vborcea closed 2 years ago

vborcea commented 3 years ago

Very nice work with the library. I have one problem with it: the WiFi.reconnect. Do you think that it's OK to make this part optional? Like, when the NTP.begin is called to receive a parameter that will say if the library should call the reconnect or not? Please note that some projects are already handling these Wifi problems and the WifiReconnect improvement overlaps with them. I can make a PR with this if you think that it's OK with you.

gmag11 commented 3 years ago

Hi, this is a nice idea. I'll implement it with a optional parameter bool manage_wifi with true as default, so that it can be disabled if you like. I'll put a note here when it is in dev branch. Thanks!

gmag11 commented 3 years ago

It is there. Please test it and give me some feedback here :)