gmag11 / ESPNtpClient

High accuracy NTP library for ESP32 and ESP8266
MIT License
118 stars 25 forks source link

[pio] Error: Nothing to build. Please put your source code files #3

Open hpsaturn opened 3 years ago

hpsaturn commented 3 years ago

I think that we have a issue with pio run on root directory:

after clone, when I run it, I have on all environments:

Error: Nothing to build. Please put your source code files to '/home/avp/tmp/src/ESPNtpClient/examples' folder
========================================================= [FAILED] Took 0.26 seconds =========================================================

Environment            Status    Duration
---------------------  --------  ------------
advanced_esp32         FAILED    00:00:00.252
advanced_esp8266       FAILED    00:00:00.323
esp32_basic_example    FAILED    00:00:00.252
esp8266_basic_example  FAILED    00:00:00.256
esp32_led_flasher      FAILED    00:00:00.250
esp8266_led_flasher    FAILED    00:00:00.257
==================================================== 6 failed, 0 succeeded in 00:00:01.591 ====================================================
hpsaturn commented 3 years ago

I tryed to replicate it in my library, and I have the same issue on *.ino projects, but in my platformio example, works fine:

https://github.com/kike-canaries/canairio_sensorlib/blob/av/ci_improvement/platformio.ini

Later, I'll try to test the wildcard, but is weird because works fine only for this directory.

gmag11 commented 3 years ago

I do not recommend building that from root folder. Better, import an example as an Arduino project and build it individually. That plaformio.ini on root is only used for development testing

hpsaturn commented 3 years ago

I'm just using platformio, and all works fine, but I was try to add a workflow on your repo, because it has not CI, for this reason I think that issue should be to resolve. The idea be a send a pull request with that. Let me review the issue..

gmag11 commented 3 years ago

In order to compile all variants from root you need to rename ino files to cpp. I guess it is a PlatformIO bug. I'm not an expert on CI (at all) so that's great if you add any feature in that way

hpsaturn commented 3 years ago

I added a PR for that the proyect will have a continous integration with github workflow, for now it only will be test the two architectures. But maybe a better clean solution is fix the *.ino files issue.

gmag11 commented 3 years ago

Thank you!!!

hpsaturn commented 3 years ago

No problem, but we could leave open this issue because the PR only give CI compiling test feature to this library, but this issue exists yet.

gmag11 commented 3 years ago

Sure!