search

gmailgem / gmail

A Rubyesque interface to Gmail, with all the tools you'll need.
Other
397 stars 119 forks source link

Fix tests on Travis #129

Closed bootstraponline closed 9 years ago

bootstraponline commented 9 years ago

From @bootstraponline on January 14, 2015 2:3

Tests are kind of limited if they're not run automatically in CI. Travis has the ability to encrypt credentials which would enable the gmail specs to run automatically.

Copied from original issue: nu7hatch/gmail#129

bootstraponline commented 9 years ago

From @johnnyshields on January 15, 2015 4:19

I've merged in my earlier PR which includes Travis support. Travis encryption is not ideal since it doesn't work with Pull Requests.

bootstraponline commented 9 years ago

sounds good. :+1:

bootstraponline commented 9 years ago

I think the integration hook isn't setup because there are no builds on travis.

https://travis-ci.org/nu7hatch/gmail

bootstraponline commented 9 years ago

From @johnnyshields on January 15, 2015 16:23

We need @nu7hatch to setup Travis since it requires repo owner permission, and he's hard to track down. I've raised #131 to move to a new repo which we maintain, if all are agreed will do soon.

johnnyshields commented 9 years ago

Repo now migrated, next step is to actually fix the tests in a PR.

bootstraponline commented 9 years ago

I'm looking at some of the errors on Travis such as:

Couldn't login to given GMail account: ki0zvkyi1yzgy7xu4f4dh46nqrcecm@gmail.com (Too many simultaneous connections. (Failure))

and I think the only way we're going to get stable results is via mocking.

johnnyshields commented 9 years ago

Yeah I agree. It would be nice if we could run tests in "mock mode" and "real mode" via an environment variable. Then could have "real mode" be an allowed failure on Travis, so we can at least check it from time to time.

bootstraponline commented 9 years ago

I think #141 is on the right track. :+1:

To set expectations, I don't anticipate having much time to contribute to the gem. I'm using it at work for one project and am interested in making sure that the gem continues to work reliably.

bootstraponline commented 9 years ago

GoGaRuCo 2014- Taking over Someone Else's Open-Source Projects - an interesting presentation. It'd be great if we had a lead dev.

johnnyshields commented 9 years ago

Good talk, a lot of good ideas in one place. I actually know this guy via Github and I've helped him with a few project takeovers, one of them being https://github.com/aq1018/mongoid-history.

Thanks for your help!

johnnyshields commented 9 years ago

I'm going to close this issue in favor of #143 and the various other open pull requests which contain specs.