search

gmailgem / gmail

A Rubyesque interface to Gmail, with all the tools you'll need.
Other
397 stars 119 forks source link

update archive! method #186

Closed nancyhawa closed 9 years ago

nancyhawa commented 9 years ago

I added a method to locate a message by message_id outside of the inbox so that the archive method will work if the user is working within their inbox.

Right now it is slow - I added a comment with a piece of code that I think should have made it faster but which I could not get to work, possibly because of a separate bug.

--Nancy

johnnyshields commented 9 years ago

@nancyhawa I've had the same issue. It seems to have broken since the previous released version (0.4.2). Can you possibly investigate the difference between 0.5.x and 0.4.2, and see if 0.4.2 has better performance?

(Try using ActiveSupport's Benchmark.measure { } function)

asiniy commented 9 years ago

+1

johnnyshields commented 9 years ago

@nancyhawa I like @asiniy's approach in PR #195 which implements a Gmail server query instead of your client-side select{ } call, we should do it the server-side way to fix the archive method.

asiniy commented 9 years ago

@johnnyshields so maybe you'll close this pr?