search

gmarcais / Jellyfish

A fast multi-threaded k-mer counter
Other
460 stars 136 forks source link

Enable build on 32bit architectures #202

Closed mr-c closed 5 months ago

mr-c commented 6 months ago

We've been carrying this patch in Debian since 2020. Optionally we can stop building for 32-bit architectures, which I find reasonable for bioinformatic software.

gmarcais commented 5 months ago

I honestly never really considered 32 bit machines, so I tried cross-compilation to i686. The provided patch does fix the compilation, but unit testing fails. Only one failure, which is much less than I feared, but still, it begs the question of the value to fix it. Are there any known users of Jellyfish on 32-bit architecture?

Given the circumstances, I would rather stop building for 32-bit architecture.

mr-c commented 5 months ago

I don't have architecture-specific details, and I'm happy to drop 32-bit builds from our side. (Bio)Conda isn't building for 32-bit systems, for example

gmarcais commented 5 months ago

So let's drop 32-bit systems. I'll update the README. Thanks.