search

gmarkall / manycore_form_compiler

MCFC is deprecated. See https://code.launchpad.net/~grm08/ffc/pyop2
https://code.launchpad.net/~grm08/ffc/pyop2
GNU General Public License v3.0
3 stars 1 forks source link

Rework canonicaliser #11

Closed kynan closed 13 years ago

kynan commented 13 years ago

This looks great!

Only 3 minor points:

  1. --objvisualise in the frontend currently has no effect (got borked in the merge)
  2. I wouldn't have removed -p | --print, see comment on 75746dda
  3. Should ObjectVisualiser print the exceptions it catches? See comment on ab4e445a
kynan commented 13 years ago

I fixed 1.