search

gmarkall / manycore_form_compiler

MCFC is deprecated. See https://code.launchpad.net/~grm08/ffc/pyop2
https://code.launchpad.net/~grm08/ffc/pyop2
GNU General Public License v3.0
3 stars 1 forks source link

uflObjects only needs to hold forms #46

Open kynan opened 12 years ago

kynan commented 12 years ago

canonicalise iterates the entire namespace and stores (preprocessed) Forms, Coefficients and Arguments in a dictionary uflObjects (attribute of the equation object). This dictionary is later only used in drive, where first of all only the forms are filtered out and these are processed. Therefore, there is in fact no need to add anything but the forms to uflObjects in the first place.

gmarkall commented 12 years ago

Coefficients are needed - see FluidityEquation._getCoeffName. Arguments don't appear to be needed, but removing them changes the order in which the local assembly kernels are generated. We'll really need to test the change with buildbot, as it will be difficult to interpret the diff.

Given that this is a trivial change, I think we should concentrate on other issues for now.

kynan commented 12 years ago

Absolutely correct, sorry for overlooking that. I agree it's nothing to worry about for now.