search

gmarkall / manycore_form_compiler

MCFC is deprecated. See https://code.launchpad.net/~grm08/ffc/pyop2
https://code.launchpad.net/~grm08/ffc/pyop2
GNU General Public License v3.0
3 stars 1 forks source link

getFieldFromCoeff in FluidityEquation returns fields we don't have in the cuda state #58

Closed gmarkall closed 12 years ago

gmarkall commented 12 years ago

FluidityEquation.getFieldFromCoeff returns the first field that it finds in the state with a given coefficient. This isn't always safe, since the state can contain fields that we haven't copied to the GPU (and therefore isn't suitable as a field which we can copy to make a temporary field).

For example, it will sometime return the AbsoluteDifference field, which is a diagnostic field and isn't actually used in a UFL equation.

gmarkall commented 12 years ago

Fixed by https://github.com/gmarkall/manycore_form_compiler/commit/15ee37284b8c299bb4c373f37308d82dc014d8f2