gmarkall / manycore_form_compiler

MCFC is deprecated. See https://code.launchpad.net/~grm08/ffc/pyop2
https://code.launchpad.net/~grm08/ffc/pyop2
GNU General Public License v3.0
3 stars 1 forks source link

SymbolicValues used in forms should generate kernel arguments #65

Open kynan opened 12 years ago

kynan commented 12 years ago

At the moment we statically add a kernel argument for the symbolic value dt no matter whether it is actually used in the form or not. On the other hand we never generate kernel parameters for any other symbolic values that may be used in forms.

With the current code structure this is slightly messy to implement, since the form expressions are analysed by ExpressionBuilder, whereas kernel parameters are generated by FormBackend. That means ExpressionBuilder.build will need to return a list of SymbolicValues used in the expression for which to generate kernel arguments.