search

gmarkall / manycore_form_compiler

MCFC is deprecated. See https://code.launchpad.net/~grm08/ffc/pyop2
https://code.launchpad.net/~grm08/ffc/pyop2
GNU General Public License v3.0
3 stars 1 forks source link

Fix op2 rhs assembly #66

Closed gmarkall closed 12 years ago

gmarkall commented 12 years ago

The code generation differed from the OP2 spec in two ways:

  1. The local tensor was zeroed in vector assembly kernels. This should not be done.
  2. Scalar coefficients were treated as pointers to scalars, when they should have been treated as pointers to arrays of length 1.

These two problems are fixed in this pull request.

kynan commented 12 years ago

Looks great! Let's see if merging this solves some more issues.

gmarkall commented 12 years ago

That's rather optimistic! :-)