gmarkall / manycore_form_compiler

MCFC is deprecated. See https://code.launchpad.net/~grm08/ffc/pyop2
https://code.launchpad.net/~grm08/ffc/pyop2
GNU General Public License v3.0
3 stars 1 forks source link

Multiple integrals #67

Closed gmarkall closed 12 years ago

gmarkall commented 12 years ago

Support code generation for multiple integrals per form. Changes are:

At first it may seem odd that all the parameters of the kernels for each integral in a form take the same parameters, regardless of which coefficients they use. However, this is because the coefficients are stored per-form in the form data. Similar behaviour can be observed in FFC - all of the coefficients must be passed to the tabulate_tensor function even if it doesn't need all the coefficients for that integral.

Because these changes involved modification of the generated code, the changes have been tested first on the buildbot - all tests have passed on the devtests-grm08 and fluidity-dev-grm08 queues.

kynan commented 12 years ago

Great! I also like that building expressions is now handled in a cleaner way (i.e. the case distinction for the local tensor eliminated. Merging...