Not working with brew on OSX

thom4parisot commented 12 years ago

Installing closure compiler on OSX with brew leads to 2 things:

a binary available in the path as closure (symlink to /usr/local/Cellar/closure-compiler/<version>/bin/closure
a jar available in /usr/local/Cellar/closure-compiler/<version>/libexec/compiler.jar

The binary is only a shorthand:

#!/bin/bash
java -jar "/usr/local/Cellar/closure-compiler/20120305/libexec/compiler.jar" "$@"

I see 2 problems:

command variable hardcodes 'build/compiler.jar'
CLOSURE_PATH would necessary only
- if closure is not available system wide
- or if a specific version needs to be provided

gmarty commented 12 years ago

Can this issue be closed now? I assume your PR to brew fix it.

thom4parisot commented 12 years ago

Yep, done since a while. Once installed with brew install closure-compiler, brew --prefix closure-compiler reveals the path of the latest installed closure-compiler. Eg:

$ brew --prefix closure-compiler
/usr/local/Cellar/closure-compiler/20120710

$ tree -L 3 `brew --prefix closure-compiler`
/usr/local/Cellar/closure-compiler/20120710
├── INSTALL_RECEIPT.json
├── bin
│   └── closure-compiler
└── libexec
    ├── CONTRIBUTORS
    ├── COPYING
    ├── README
    ├── build
    │   ├── classes
    │   ├── compiler.jar
    │   ├── externs.zip
    │   └── lib
    ├── build.xml
    ├── closure-compiler.pom
    ├── contrib
    │   └── externs
    ├── externs
    │   ├── deprecated.js
    │   ├── es3.js
    │   ├── es5.js
    │   ├── fileapi.js
    │   ├── flash.js
    │   ├── gears_symbols.js
    │   ├── gears_types.js
    │   ├── gecko_css.js
    │   ├── gecko_dom.js
    │   ├── gecko_event.js
    │   ├── gecko_xml.js
    │   ├── google.js
    │   ├── html5.js
    │   ├── ie_css.js
    │   ├── ie_dom.js
    │   ├── ie_event.js
    │   ├── ie_vml.js
    │   ├── iphone.js
    │   ├── w3c_anim_timing.js
    │   ├── w3c_css.js
    │   ├── w3c_css3d.js
    │   ├── w3c_dom1.js
    │   ├── w3c_dom2.js
    │   ├── w3c_dom3.js
    │   ├── w3c_elementtraversal.js
    │   ├── w3c_event.js
    │   ├── w3c_event3.js
    │   ├── w3c_geolocation.js
    │   ├── w3c_indexeddb.js
    │   ├── w3c_navigation_timing.js
    │   ├── w3c_range.js
    │   ├── w3c_selectors.js
    │   ├── w3c_xml.js
    │   ├── webgl.js
    │   ├── webkit_css.js
    │   ├── webkit_dom.js
    │   ├── webkit_event.js
    │   ├── webkit_notifications.js
    │   ├── webstorage.js
    │   └── window.js
    ├── gen
    │   └── com
    ├── javadoc
    │   ├── allclasses-frame.html
    │   ├── allclasses-noframe.html
    │   ├── com
    │   ├── constant-values.html
    │   ├── deprecated-list.html
    │   ├── dev_javadoc.css
    │   ├── help-doc.html
    │   ├── index-all.html
    │   ├── index.html
    │   ├── overview-frame.html
    │   ├── overview-summary.html
    │   ├── overview-tree.html
    │   ├── package-list
    │   ├── resources
    │   └── serialized-form.html
    ├── lib
    │   ├── ant-launcher.jar
    │   ├── ant.jar
    │   ├── args4j.jar
    │   ├── caja-r4314.jar
    │   ├── guava.jar
    │   ├── jarjar.jar
    │   ├── json.jar
    │   ├── jsr305.jar
    │   ├── junit.jar
    │   ├── protobuf-java.jar
    │   └── rhino
    ├── src
    │   └── com
    ├── test
    │   └── com
    └── tools
        └── maven-ant-tasks-2.1.1.jar

gmarty commented 12 years ago

Great! I updated the README accordingly. Please review these sections:

And let me know if anything needs fixing.

thom4parisot commented 12 years ago

It's okay :-)

gmarty / grunt-closure-compiler

Not working with brew on OSX #2