search

gmaruzz / saraphone

SaraPhone is an open source SIP WebRTC phone, complete with HotDesking, Redial, BLFs, MWI, DND, PhoneBook, Hold, Mute, Notifications. SaraPhone is fully integrated with FusionPBX. Based on SIP.js, SaraPhone works with all WebRTC compliant servers: FreeSWITCH, Asterisk, OpenSIPS, Kamailio, etc. SaraPhone gets its name from Giovanni's wife, Sara.
Mozilla Public License 2.0
153 stars 72 forks source link

FEATURE REQUEST: use username channel var instead of caller_id_number #22

Closed rbetancor closed 4 years ago

rbetancor commented 4 years ago

That will allow to use non numerical extensions that have numerial alias_number, so when the saraphone.lua tries to find if the caller is a SaraPhone device for the bind_digit_action and the fake ringback, that part will work in any usecase.

gmaruzz commented 4 years ago

not understood, can you elaborate / explain more?

gmaruzz commented 4 years ago

ah ok, now understood

actually in latest version it does not check what kind of device is anymore it always bind_digit_action

you may want to:

git stash; git pull; git stash apply

rbetancor commented 4 years ago

In latest version on master, you still check if the device is SaraPhone for the ringback

Take a look at my PR