search

gmauleon / alertmanager-zabbix-provisioner

Zabbix provisioner to automatically create host/items/triggers from Prometheus rules
13 stars 12 forks source link

Fix Prometheus rules parsing, add tests #8

Closed paskal closed 5 years ago

paskal commented 5 years ago

Fix Prometheus rules parsing (fix #6) (tested with Prometheus 2.7.1), add tests to make sure it works as expected.

paskal commented 5 years ago

@gmauleon could you please look into this one as well? It replaces #7, no need to merge #7 if this will be merged.

paskal commented 5 years ago

@gmauleon will that be merged?

paskal commented 5 years ago

@gmauleon could you please look into it?

gmauleon commented 5 years ago

I will probably not merge that, sorry. I definitely can't spend more time on this and anyway I would rather integrate the new API prometheus is exposing directly instead of custom parsing, aka https://github.com/gmauleon/alertmanager-zabbix-provisioner/issues/4

However if you have a fork on github, I would gladly point to your fork in the readme so people would go directly on your project (if you want to keep maintaining it in the future).

Let me know. Thanks.

paskal commented 5 years ago

Sad I've put an effort into doing this which will never get released now.