search

gmazelier / gradle-jasperreports

Provides the capability to compile JasperReports design files.
https://plugins.gradle.org/plugin/com.github.gmazelier.jasperreports
Apache License 2.0
25 stars 20 forks source link

Parameter to use relativ outputDir #5

Closed rankec closed 9 years ago

rankec commented 9 years ago

Hey, your plugin is really nice but for my company we have a different project structure. So we can't use your plugin out of the box. Because of it i added a new parameter 'useRelativeOutDir'. If you set the parameter to true the output dir is relative to java classpath.

For example our project structure is: com.rankec.jaspertest.report.jrxml Then the output dir is: ${project.buildDir}/classes/main/com/rankec/jaspertest/report.jasper

atm the default is just: ${project.buildDir}/classes/main/report.jasper

I hope you will merge it and maybe release it as 0.2.1 :)

Best regards

gmazelier commented 9 years ago

Hi,

Thanks for the patch! I like the idea.

Would you mind using tabs instead of spaces to indent your code for this project? This will make the diffs more readable also. When the pull request will be merged, I will release a new version.

Gaylord

rankec commented 9 years ago

Now the changes are a lot of better to read. Often there are only some spaces removed. So it looks like i added a new line. Do you think its acceptable now?

gmazelier commented 9 years ago

Sounds great. Thanks!

gmazelier commented 9 years ago

Thanks for the patch. Release 0.2.1 will be available soon.