search

gmdfalk / blockify

mute spotify adverts on linux
MIT License
354 stars 42 forks source link

Could not find Spotify PID #9

Closed Timidger closed 10 years ago

Timidger commented 10 years ago

When I run blockify as a normal user (with Spotify definitely running, checked with ps -A ) get:

 Could not get Spotify PID: list index out of range

Now, I believe the issue is how blockify looks for the PID of spotify, because when I run blockify as root, I don't get this error. Of course, one should not run a program as root for it to function, so this should probably be fixed

Timidger commented 10 years ago

I have found, after some experimentation, that it causes this error if nothing has yet been played for Spotify, though the program continues to function normally. This is not important, though the error message was slightly confusing

gmdfalk commented 10 years ago

Thanks mate, that message was indeed misleading. I pushed a couple of changes including one where it'll display "No song playing" as song status in this scenario.

Timidger commented 10 years ago

Thanks :)

As a side question, is the small amount of ad that is heard when the program unmutes from the fade from Spotify or from your one-second check not being fast enough?

gmdfalk commented 10 years ago

Hey,

if anything, the one second check is too fast. So yeah, it's the fade. I changed the delay down from 1s to 0.25s which makes blockify a lot more responsive. If that's still not snappy enough, one could lower that update_interval to 100ms or less but that seems like a waste of CPU cycles. I pushed a lot of other fixes too so you probably want to get the current version. Related: Until I can figure out how to detect ads when Spotify is minimized or find a smarter way to block ads in the first place there probably won't be many changes to Blockify after this message.

Cheers

On 02/05/14 15:05, Preston Carpenter wrote:

Thanks :)

As a side question, is the small amount of ad that is heard when the program unmutes from the fade from Spotify or from your one-second check not being fast enough?

Reply to this email directly or view it on GitHub: https://github.com/mikar/blockify/issues/9#issuecomment-42029252