support for multiple OSs

jtwhite79 commented 2 years ago

Hey Rui - Im working thru the notebooks and Im running into issues with support for non-windows systems. Ive reworked it some to include support for mac, linux, and windows as far as binaries are concerned (added HBD some). But in the pestpp-glm notebooks, the existing template dir is using double backslash to located org and mult files (probs cause the pstfrom part was run on a windows machine). So some options:

rerun the pstfrom part each time on the fly in HBD
use the python-less mf6 freyberg setup (the one in the pest++ v5 report) for these notebooks and do the pstfrom stuff more explicitly later.

Im leaning toward the first one. Is that ok with you?

rhugman commented 2 years ago

Hi Jeremy,

Sorry about that. I am not too used to working across OS's - didn't think to catch it.

Prefer the 1st option as well; there are already too many PEST setups as it is...

Just to be clear, you are suggesting calling HBD in each notebook to run pstfrom to update the tutorial-specific folder? This would still allow people to drop-in at any specific tutorial. Sounds good.

jtwhite79 commented 2 years ago

yeah exactly - we would just run pstfrom on-demand within HBD. I'll work on this - hopefully a new pull request tomorrow.

rhugman commented 2 years ago

OK, thanks. If you prefer I can do it - don't want to waste too much of your time on these trivial issues.

jtwhite79 commented 2 years ago

That's awesome - I'll leave that to you- lemme if you need help. Where should I concentrate now?

rhugman commented 2 years ago

Perhaps check the pstfrom notebook? To make sure I haven't done anything particularly stupid. It feeds in to everything else, so better to catch any issues early.

The next "big" thing would be to start on the pestpp-da notebook/s? I am guessing it will be somewhat standalone anyway, so not too affected by other ongoing changes.

jtwhite79 commented 2 years ago

Kewl. I'm on it

rhugman commented 2 years ago

Hey Rui - Im working thru the notebooks and Im running into issues with support for non-windows systems. Ive reworked it some to include support for mac, linux, and windows as far as binaries are concerned (added HBD some). But in the pestpp-glm notebooks, the existing template dir is using double backslash to located org and mult files (probs cause the pstfrom part was run on a windows machine). So some options:

rerun the pstfrom part each time on the fly in HBD

use the python-less mf6 freyberg setup (the one in the pest++ v5 report) for these notebooks and do the pstfrom stuff more explicitly later.

Im leaning toward the first one. Is that ok with you?

This is quickly becoming a major pain. Allowing them to drop in at any point means that we need to rerun all the previous steps (not just pstfrom) because of the interim .pst files. Easy enough for the obs&weighting, but gets more complex (and more runtime) the further we go along (i.e. glm2, fosm, etc). Making people go through each step themselves would make it easier to fix.

Options that I see:

Convoluted network of steps to ensure that necessary files are available. Essentially requires repeating steps to create .pst files, while avoiding running pestpp. Can't simply run the notebooks as is; requires a workaround. Simplest would be to have functions in HBD that do the same thing as the notebooks - but high potential for problems to creep in down the line.
Is it possible to blast through all .pst and org/mult folders to restructure them according to OS? I am not familiar enough with how these are organized.
Accept defeat and say: "if you want to run these yourself, then you need to run them in the following order..." (as in your original repo). Provide the html's/.pdf versions of notebooks (the plan anyway).

Thoughts?

jtwhite79 commented 2 years ago

It is a major pain, Rui. Im comfortable with the last option (just do it in order) b/c that is how we have done it before. I guess intro notebooks can be done a la carte. But for the part2 workflow notebooks, I think it just needs to be done in order. @mnfienen might have some thoughts here too...we had some checks at the start of those notebooks to make sure some existing files/folders could be found, and, if not, we would give a semi-meaningful message about what needed to be done first...

rhugman commented 2 years ago

if they wish to run them, users must run notebooks in order.

gmdsi / GMDSI_notebooks

support for multiple OSs #11