Starting to review - Githubissues

gmdsi / GMDSI_notebooks

python-based predictive groundwater modeling workflow examples

GNU General Public License v3.0

58 stars 35 forks source link

Starting to review #52

Closed mnfienen closed 2 years ago

mnfienen commented 2 years ago

Hey @rhugman and @jtwhite79:

I'm finally digging into these notebooks (nice work!). I'm working in a branch called mike_review. Looks like I will need more rights to push the branch.

If it's cool, I can keep track of comments in an issue to make it easier to see what I comment on.

Also, I have a path to USGS review and should be pretty straightforward.

Let me know if this sounds good.

rhugman commented 2 years ago

Thanks @mnfienen, that's great!

Re- issues as comments: works for me. Let me know once you are at a point that I can start working on addressing them.

You have Admin rights to the organization/repo and should be able to push the branch:

mnfienen commented 2 years ago

cool - thanks. I'll keep rolling with the issues approach then. Not sure why I can't push - I'll sort that out