gmdsi / GMDSI_notebooks

python-based predictive groundwater modeling workflow examples
GNU General Public License v3.0
48 stars 31 forks source link

intro to freyberg notebook snaggles #65

Closed kmarkovich-intera closed 1 year ago

kmarkovich-intera commented 1 year ago

Hello, I am working through the develop branch notebooks and ran into 2 issues with the intro to freyberg notebook. First, the sim.run_simulation() command throws an "Exception: The program mf6.exe does not exist or is not executable." I confirmed that mf6.exe is in the sim_ws and runs fine outside of the notebook, so I am not sure why it's not finding it. FWIW I am running these on a PC and with the gmdsi conda env.

Second, the obs v sim plot for GAGE-1 throws an error due to a key mismatch. In the truth csv it's called "GAGE-1" but in the obs file and csv output it is "GAGE_1." Renaming the former to be GAGE_1 fixes the problem.

mnfienen commented 1 year ago

Hi @kmarkovich-intera - thanks for finding this! First question is are you running in the main branch or develop? This is all working for me in develop.

On the exe, can you confirm whether mf6.exe got properly copied over into the run directory (e.g. freyberg_mf6?

kmarkovich-intera commented 1 year ago

I'm on the develop branch and yes mf6.exe was properly copied. I can run the model with it directly, just not via sim.run_simulation(). Super weird!

mnfienen commented 1 year ago

that is weird! Have you pulled develop? We merged in a bunch of stuff yesterday.

Also, strangely, I'm seeing gage-1 in the sfr.obs file and GAGE-1 in the sfr.csv file, so something is mismatched....

mnfienen commented 1 year ago

Maybe to confirm, this is what I see in git log for develop:


Merge: 2bd8d76 44c90ae
Author: mnfienen <mnfienen@usgs.gov>
Date:   Wed Sep 7 12:00:45 2022 -0500

    Merge pull request #64 from mnfienen/mike_review_2

    Mike review 2

commit 44c90aedf3bade44014440c13bcd42fb9fa9fdb9
Merge: 926e011 9fa3fd3
Author: mnfienen <mnfienen@usgs.gov>
Date:   Wed Sep 7 09:40:37 2022 -0500

    Merge pull request #2 from jtwhite79/mike_review_2

    Mike review 2
kmarkovich-intera commented 1 year ago

I forked it yesterday, so that might be the issue...

mnfienen commented 1 year ago

sounds likely :)

kmarkovich-intera commented 1 year ago

Merge: 2bd8d76 44c90ae Author: mnfienen mnfienen@usgs.gov Date: Wed Sep 7 12:00:45 2022 -0500

Merge pull request #64 from mnfienen/mike_review_2

Mike review 2

commit 44c90aedf3bade44014440c13bcd42fb9fa9fdb9 Merge: 926e011 9fa3fd3 Author: mnfienen mnfienen@usgs.gov Date: Wed Sep 7 09:40:37 2022 -0500

Merge pull request #2 from jtwhite79/mike_review_2

Mike review 2
kmarkovich-intera commented 1 year ago

Seems up to date with yours? Now I'm really confused

mnfienen commented 1 year ago

me too!!!

I hate to suggest, but maybe clone a gain to be sure?

image
kmarkovich-intera commented 1 year ago

Will do!

mnfienen commented 1 year ago

sorry for the trouble!

kmarkovich-intera commented 1 year ago

Honestly, I blame this new Dell that I was forced to receive. Deleted repo, fresh clone from gmdsi repo (not my fork), switched to develop branch, and boom, same issue!

kmarkovich-intera commented 1 year ago

Just gave it the full exe path and it worked... maybe it was expecting to see it one level up from sim_ws? Do you have mf6.exe in your root path? I don't on this machine image

mnfienen commented 1 year ago

Oh man - yeah, that makes sense. I do have mf6 in my path. Crumbs. Thanks for the catch! I'll commit up a change.

I'm still confused about the GAGE_1 vs. GAGE-1 issue. I don't see GAGE_1 anywhere.....

kmarkovich-intera commented 1 year ago

obs_data.csv This is the obs_data.csv in models/daily_freyberg_mf6_truth/ from my fresh pull.

mnfienen commented 1 year ago

right. cool - it's GAGE-1 in there so should work no?

kmarkovich-intera commented 1 year ago

Oh yeah! seems like re-pulling fixed that one. Nice.

mnfienen commented 1 year ago

sweet! so you are good then?

kmarkovich-intera commented 1 year ago

Yes, thanks! Onto the next one...

mnfienen commented 1 year ago

awesome! closing then