gmdsi / GMDSI_notebooks

python-based predictive groundwater modeling workflow examples
GNU General Public License v3.0
48 stars 31 forks source link

"freyberg_1_local_sensitivity" - Issue the Spatial display section of the notebook #76

Closed Paszka1 closed 1 year ago

Paszka1 commented 1 year ago

Call to function hbd.plot_arr2grid(ident_vals, working_dir) in cell 22 is apparently done erroneously. The order of parameters in array ident_vals doesn't match the order in file ˙hkpp.dat˙, I.e., the order in the former array is based on identifiability. As a result, identifiability values are saved erroneously in the new_ppfile file identpar.dat, resulting in wrong interpolation.

Another thing I don't understand is that the actual values in file identpar.dat do not match the values in the ident_vals array at all. Here I couldn't figure out the reason, so I may be missing something. I.e., line 782 in herebedragons.py writes this file, and based on the assignment in line 780, column parval1 should have the values from ident_vals.

rhugman commented 1 year ago

Thanks for noticing that. Should be fixed now in the develop branch with #78.