search

gmdsi / GMDSI_notebooks

python-based predictive groundwater modeling workflow examples
GNU General Public License v3.0
48 stars 31 forks source link

fix typos, make pedantic grammar tweaks, and modify wording #90

Open JackElsey opened 10 months ago

jtwhite79 commented 10 months ago

Thanks @JackElsey . We might hold off on merging this pr until after the upcoming course just to make sure everyone has a consistent notebook version...

JackElsey commented 10 months ago

OK, I'll hold off on making more commits until I've worked through more of the tutorials then.

JackElsey commented 10 months ago

There are a couple probable equation typos that you may want to be aware of:

First, I don't think the variogram formula here should have $h$ in the denominator.

$$\hat{\gamma}\left(h\right)=\frac{1}{2\left(h\right)}\left(z\left(x_1\right)-z\left(x_2\right)\right)^2$$

Second, the Baye's theorem equation here has an unnecessary > in the numerator.

$$P\left(\boldsymbol{\theta}|\textbf{d}\right)=\frac{P\left(\textbf{d}|\boldsymbol{\theta}\right) P\left> (\boldsymbol{\theta}\right)}{P\left(\textbf{d}\right)}$$

briochh commented 10 months ago

Hey @JackElsey, I have switched this PR over to the develop branch, so we can continue to field contributions without disrupting the main branch till after the course. Feel free to keep pushing to it.