search

gmegan / specification

OpenSHMEM Application Programming Interface
http://www.openshmem.org
1 stars 0 forks source link

PE_size / PE_stride should be greater than zero #115

Open davidozog opened 5 years ago

davidozog commented 5 years ago

https://github.com/gmegan/specification/blob/8961ba4b459b4be6fdd08aefcb8107e58de83f3a/example_code/shmem_team_split_strided.c#L21

If this example is run with a single PE, then PE_size is 0. This is not allowed in active-set based collectives as per https://github.com/openshmem-org/specification/pull/209, and I think it's not allowed in team creation as well, correct? In the latest Teams API document, Section 10.9 (Collectives Routines) marks the requirement that PE_size > 0 as deprecated, so it may not be accounted for in shmem_team_split_strided.

A similar concern might exist for PE_stride: #209 requires logPE_stride to be greater than or equal to zero, so I presume PE_stride (linear) should be strictly greater than 0.

Should we update the #209 text to work for teams, and check for at least 2 PEs in the shmem_team_split_strided example?

gmegan commented 5 years ago

Move deprecated text from active sets collectives description of stride into team strided and say that invalid teams are not created.