It is bit strange to have the shmem_team_config_t as an INOUT option in the team split operations and then also have options to retrieve the configuration separately using shmem_team_get_config - users loosing the data midway?
Even though that isn't the main issue - do the implementations need to maintain the user input along with the actual value?
I would prefer the following semantics:
Make the configuration an IN parameter rather than INOUT - so this should follow in passing the actual value rather than a pointer to the configuration argument. As the configuration is also passed as a hint rather than a hard requirement - this seems useful.
It is bit strange to have the
shmem_team_config_tas anINOUToption in the team split operations and then also have options to retrieve the configuration separately usingshmem_team_get_config- users loosing the data midway?Even though that isn't the main issue - do the implementations need to maintain the user input along with the actual value?
I would prefer the following semantics: Make the configuration an
INparameter rather thanINOUT- so this should follow in passing the actual value rather than a pointer to the configuration argument. As the configuration is also passed as a hint rather than a hard requirement - this seems useful.