Open nspark opened 5 years ago
Other thoughts:
shmem_team_n_pes
return a size of zero for SHMEM_TEAM_INVALID
? (Personally, I like 0 vs. -1 for team size, since we already specify that a valid team always has at least one PE in it.)SHMEM_CTX_DEFAULT
to this routine." removed from the notes for shmem_ctx_destroy
?
shmem_ctx_destroy
destroys a context that was created by a call to shmem_ctx_create
or shmem_team_create_ctx
", and the default context was not created by the userland API.For the return value of shmem_team_split_strided
, I think I'd prefer that:
new_team
, zero is returned to all PEs in new_team
, and a nonzero value is returned to all other PEs.parent_team
.That is, any PE that calls shmem_team_split_strided
and has new_team
updated to equal SHMEM_TEAM_INVALID
also gets a nonzero return value..
Extracting items from #124, the 5/21 reading raised some specific questions about various teams features that need discussion by the Teams WG. These are listed here so as not to be lost amidst the sea of editorial comments from the reading.
shmem_team_config_t
SHMEM_TEAM_WORLD
?shmem_team_get_config
returns the "unspecified" sentinel value or the actual value for which the team was configuredshmem_team_destroy
shmem_finalize
destroys all teams and associated shared contexts. Clarify return valueshmem_team_split_strided
new_team
is created successfully, is a zero value returned to all PEs inparent_team
or only those innew_team
?new_team
cannot be created by any PE (e.g., due to resource constraints), do all PEs return a nonzero value?