search

gmegan / specification

OpenSHMEM Application Programming Interface
http://www.openshmem.org
1 stars 0 forks source link

Clarify return value w/ invalid team_split_strided #161

Open davidozog opened 4 years ago

davidozog commented 4 years ago

The first change attempts to clarify what happens when parent_team is invalid - I find the original sentence a little difficult to parse. Is this better?

I'm also unsure whether setting new_team to SHMEM_TEAM_INVALID is a "successful" creation of new_team and whether the return value should be nonzero. Either way is fine with me, but in this PR I assume this case is "unsuccessful", so a nonzero value is returned.

nspark commented 4 years ago

I'll pull this change into my branch from the F2F, which has a few extra fixes related to error behavior. I'll get that ready to read at the next call.

This change will have to be replicated and adapted in a number of other places as well.

nspark commented 4 years ago

See https://github.com/openshmem-org/specification/pull/305