search

gmeghnag / omc

OpenShift Must-Gather Client
Apache License 2.0
153 stars 63 forks source link

Support archive/must-gather files compressed with XZ #168

Closed mtulio closed 4 months ago

mtulio commented 5 months ago

Creating support of must-gather files compressed with XZ.

mtulio commented 5 months ago

Hey @gmeghnag do you think supporting XZ compressed files can contribute to the project? I am working in projects which we are compressing must-gather with XZ to distributed across CI results with smaller files (sometimes 5x+). Having omc support of reading xz compressed must-gather archives will help to decrease steps while reading those files using that amazing tool. Looking forward to hear from you if it makes sense. Local tests works file.

I opened #169 applying gofmt to decrease the changes while reading this PR. Feel free to suggest alternatives.

Thanks.

gmeghnag commented 4 months ago

@mtulio "do you think supporting XZ compressed files can contribute to the project?" Sure! I see the tests are failing, could you please check why? We need the test to pass before approving the PR, thanks!

mtulio commented 4 months ago

@mtulio "do you think supporting XZ compressed files can contribute to the project?" Sure! I see the tests are failing, could you please check why? We need the test to pass before approving the PR, thanks!

Hi @gmeghnag, thanks for your feedback. Rebased/Fixed. Would you mind taking a look?

/assign gmeghnag