search

gmertes / NflxMultiSubs

Bilingual Subtitles for the Netflix Web App. An actively maintained fork with various bugfixes and improvements to the original NflxMultiSubs.
MIT License
172 stars 23 forks source link

Secondary subtitles are not shown after moved to next episode #15

Closed sh-cho closed 3 years ago

sh-cho commented 3 years ago

image

When I moved to next episode, secondary subtitles are checked but not shown in screen.

If I check "Off" and select the secondary subtitles again, it works fine.

("La Casa de Papel", S01 E05 -> E06)

gmertes commented 3 years ago

Hmm I can't reproduce this bug, for me it activates the subtitle correctly when going to next ep. Gonna need some more info:

  1. Which version of the plugin, which browser, and installed from where?
  2. Did you previously install the plugin manually using the zip file?
  3. Does it happen all the time when going to the next episode, or only sometimes?
  4. Could you please reproduce the bug in a new tab and then paste the output of the console log here? Make sure that logging is set to show info, warning and error.
sh-cho commented 3 years ago
  1. plugin version: 2.2.5 / chrome browser on mac: Version 95.0.4638.69 (Official Build) (arm64)
  2. I had installed this first, and found it's not working. So I removed it and installed this extension through Chrome Web Store
  3. It happens all the time

  4. image

gmertes commented 3 years ago

Thanks. That audio track error should definitely not be there 😅 It is failing to detect the audio language, and therefore can't automatically activate that language subtitle. I will investigate.

BTW, while I work on a fix you could use the 'last used' language mode instead of audio mode. If you click on the extension button it's at the bottom. Then instead of trying to match the sub language to the audio language, it will remember the language that you last selected.

sh-cho commented 3 years ago

Thanks! 😃

gmertes commented 3 years ago

Found and fixed the bug. Netflix changed the manifest format and removed the field we used to detect the default audio language. This broke the subtitle auto-activation based on audio language. So it wasn't just broken when going to the next episode, but broken completely. I couldn't reproduce it earlier because I was using the 'last used' language mode 🙃

Thanks again for your report because this was a major bug. The fix will be included in the next release (v2.2.6). You can expect the update in the next few days once it's approved by the Chrome store. In the meantime I suggest to keep using the 'last used' language mode. I'll close this issue once the update is rolled out.

gmertes commented 3 years ago

v2.2.6 with the fix is now live on both stores 🎉