search

gmertes / NflxMultiSubs

Bilingual Subtitles for the Netflix Web App. An actively maintained fork with various bugfixes and improvements to the original NflxMultiSubs.
MIT License
172 stars 23 forks source link

[Safari] Subtitles are overlapped #26

Closed sh-cho closed 2 years ago

sh-cho commented 2 years ago
image

@WingCH can you check this? :)

Version is 2.3.0 (8)

WingCH commented 2 years ago

I noticed that chrome is normal and only happens in Safari @gmertes Can give me some hints about the height control of the subtitles?

gmertes commented 2 years ago

@WingCH Probably related to this commit, did you merge it in the Safari version? Getting the original fontsize was broken, so this function was returning before it could reach the height control logic below.

WingCH commented 2 years ago

Thanks for your help. the problem is fixed after i merge latest code to safari version. I've uploaded the new version to Apple Connect, waiting apple review.

because of my negligence there is a different version problem, when I updated the apps icon last time I mistakenly upgraded the version number to 2.3.0, but the correct version number is 2.9.xxx, so now it is not synchronized, to avoid confusion I will keep the major and patch numbers synchronized in the future, the minor number is now +1

for example Original version: 2.2.10 safari version: 2.3.10

Original version: 2.3.0 safari version: 2.4.0

Original version: 2.3.99 safari version: 2.4.99

image

WingCH commented 2 years ago

The new version has been released in apple store.

If the problem is resolved, please close this issue

sh-cho commented 2 years ago

Thanks! It's ok now :)