Critical: subtitle builder is broken

gmertes / NflxMultiSubs

Bilingual Subtitles for the Netflix Web App. An actively maintained fork with various bugfixes and improvements to the original NflxMultiSubs.

MIT License

166 stars 23 forks source link

Critical: subtitle builder is broken #27

Closed gmertes closed 2 years ago

gmertes commented 2 years ago

Netflix changed something in the subtitle manifest, breaking the subtitle builder in the SubtitleFactory class. Bug is located around the ttDownloadables field and targetProfile key here, triggering the error catch below it.

This is a critical breaking bug, will investigate ASAP but may not have time until the weekend. If anyone already has a fix ready, PR is welcome.

Thanks to @lampy9 for the report! ( it is unrelated to the Safari issue :) )

gmertes commented 2 years ago

@WingCH Also pinging you here: bug has been fixed in latest commit, you could update the Safari version 🤗 You do need to check if this commit is compatible cause it introduces a new option field for the text colour, but if you use the kDefaultSettings object to populate the options it should be compatible. I bumped the minor version cause I haven't really been paying attention to semver, technically I think the text colour setting classifies as new functionality😅

WingCH commented 2 years ago

@gmertes Thanks for your notice, I just uploaded a new version to apple, this version only contains bug fixes, not updates about the settings page. The current safari version hides the settings page, because safari is not compatible with chrome.runtime postMessage, I tried to simply use browser.runtime, but it seems have other problems, the settings page does not work properly, safari is not like chrome and firefox like easy to debug😵, I need extra timeto develop these features for safari, so I choose to hide the settings page, I know this is not the solution, I will study it in my free time.