search

gmertes / NflxMultiSubs

Bilingual Subtitles for the Netflix Web App. An actively maintained fork with various bugfixes and improvements to the original NflxMultiSubs.
MIT License
166 stars 23 forks source link

Unlock all languages #34

Closed hyww closed 1 year ago

hyww commented 1 year ago

resolves #29

I found this showAllSubDubTracks option in manifest requests and it works like a charm.

This might bring a new issue, too many languages! Maybe we need a way to let users filter the languages and display only those they are interested in.

hyww commented 1 year ago

Sorry, my fault. I didn't noticed that I also installed this extension, which uses a modified version of older cadmium player. P.S. that version still uses the old subtitle downloadUrls 😂

I will close this PR and leave some comments at #29 for further discussion.

gmertes commented 1 year ago

Oh interesting, I also have a fork of netflix-1080p on my laptop so that explains the different player versions! 😅 But that one interestingly still doesn't work with showAllSubDubTracks

We may consider adding this as an optional feature and then instruct the user to install netflix-1080p ? But the original version is no longer maintained, and I don't know the impact of sticking with the older player version.