search

gmertes / NflxMultiSubs

Bilingual Subtitles for the Netflix Web App. An actively maintained fork with various bugfixes and improvements to the original NflxMultiSubs.
MIT License
172 stars 23 forks source link

[Feature Request] Filter away CC-Bracket-Annotations #46

Open dennis-mb opened 11 months ago

dennis-mb commented 11 months ago

I would like to have a toggle for each subtitel stream whether to filter away anything within square brackets and the brackets themselves.

Netflix seems to offer english subs only with CC annotations like "[birds singing]" which are annoying to me (and perhaps many other people). Especially if using english subtitels for english shows as non-native speaker, but hearing enabled person, for better comprehension.

gmertes commented 11 months ago

Hi, thanks for the suggestion! It goes a little against the core of the extension, which is to only show the subtitles as they are provided by Netflix. In some regions Netflix will provide both regular and CC English subs, making such a toggle useless. Also, I'm pretty sure there can be more in a CC sub than just brackets, sometimes there are music notes or other symbols, so would have to be thorough with this.

I'm not totally against the idea, but I'd like a more transparent implementation. Instead of a toggle I suggest to automatically insert a filtered English sub in the subtitles list whenever it is missing. Might even go a step further and do this for all languages, but it would have to be really robust first.

I will explore the above, but it is going to have to go on my todo list for now as I will be away in the coming weeks. If anyone wants to have a go at this I welcome a PR.