search

gmertes / NflxMultiSubs

Bilingual Subtitles for the Netflix Web App. An actively maintained fork with various bugfixes and improvements to the original NflxMultiSubs.
MIT License
166 stars 23 forks source link

[Firefox] [Bug] Playback speed changes inadvertently when keyboard shortcuts are used #52

Closed sloria closed 3 months ago

sloria commented 3 months ago

Version: 2.3.5 Browser: Firefox 126.0.1 OS: macOS 14.5

While viewing videos with primary and secondary subtitles enabled, the playback speed speeds up at seemingly random times to ~1.2x, without any user interaction. I've observed this on multiple videos.

sloria commented 3 months ago

Actually, I think what might be happening is that the [/] shortcut is being triggered even when other shortcuts are used. I use cmd+shift+] to switch to the next tab, and this inadvertently triggers this extension to increase the speed.

Ideally, the shortcut should only be triggered when ] is pressed on its own within the netflix tab. In the meantime, is there a way to disable this keyboard shortcut?

gmertes commented 3 months ago

Thanks for the report! Unless you modify the code and build the extension locally, there's no way to disable the shortcut.

But I will fix it, I forgot to check modifier keys. Expect a new version with the fix in the next couple days.

sloria commented 3 months ago

Thank you!

gmertes commented 3 months ago

Fixed in v2.3.6