gmertes / NflxMultiSubs

Bilingual Subtitles for the Netflix Web App. An actively maintained fork with various bugfixes and improvements to the original NflxMultiSubs.
MIT License
172 stars 23 forks source link

[ ] doesn't change speed when prompted by X-Mouse Button Control #53

Open HalBenHB opened 4 months ago

HalBenHB commented 4 months ago

I had resolved this issue before #40 I have Turkish Keyboard and Ğ and Ü keys are responsible for playback speed of this. I'm using X-Mouse Button Control applet and assigned my Mouse Button 4 and Mouse Button 5 to send [ and }. So that, I can change speed with my mouse. Well, I was able to do this as of alpha version 2.3.4, resolved in #40 Recently it broken. I can change playback speed with pressin Ğ and Ü or Shift+8 and Shift+9 (that corresponds [ and ] in Turkish Keyboard). However, I can't simulate these keystrokes in any other way. I try to send [, ğ, KeyCode.219 with X-Mouse Button Control and Autohotkey but the extension didn't respond it.

I've just uninstalled the extension, downloaded the 2.3.4-alpha and (since Chrome doesn't allow manifest_version:2) I've changed it as below and installed that version. It worked again. I tried to track why newer versions doesn't allow me to virtually simulate keystrokes with other apps but only allow me to press on keyboard, couldn't find the reason exactly. For now, I'm using this older version with a simple update to the manifest.json, but I find it useful to not have this issue in the current versions for a freer use of the extension.

{ "short_name": "NflxMultiSubs", "description": "Bilingual Subtitles for Netflix (fixed)", "version": "3.0.0", "name": "NflxMultiSubs 2021 (Netflix Multi. Subtitles)", "manifest_version": 3, "author": "Dan Chen, Gert Mertes", "permissions": [ "storage" ], "host_permissions": [ "https://www.netflix.com/*", "https://assets.nflxext.com/*" ], "background": { "service_worker": "background.min.js" }, "action": { "default_icon": "icon-gray.png", "default_popup": "settings.html" }, "icons": { "16": "icon16.png", "32": "icon32.png", "128": "icon128.png", "512": "icon.png" }, "content_scripts": [ { "matches": [ "https://www.netflix.com/*" ], "js": [ "content.min.js" ], "run_at": "document_start" } ], "externally_connectable": { "matches": [ "https://www.netflix.com/*" ] }, "web_accessible_resources": [ { "resources": ["nflxmultisubs.min.js"], "matches": ["https://www.netflix.com/*"] } ] }