Ported to Swift 3. Tests have passed 🎉

codeOfRobin commented 8 years ago

@gmertk So, can we merge this PR?

chrisballinger commented 7 years ago

I'm not sure if anyone is maintaining this library anymore.

@gmertk Can someone be added as a maintainer?

codeOfRobin commented 7 years ago

@chrisballinger I'd be happy to btw, if @gmertk is okay with it. I have a few alternate ideas in mind though (involving using UITextField's rightView property), but this is a good starting point as any.

gmertk commented 7 years ago

Sure I would be happy to add maintainer(s) since I don't have time lately. I will merge this over the weekend

gmertk commented 7 years ago

Hey @codeOfRobin Thank you for this PR. I came here to merge this. However, this is doing much more than porting it to Swift 3. The example looks a lot different. It fails when I write some text, and delete it.

I can add you as a maintainer, but you should keep the library simple, and clear from your company's needs like changing the default domain, color, or adding a method like chalJaBC (not sure why we need this).

codeOfRobin commented 7 years ago

Got it. I'll keep a separate fork, and we can try merging some changes from that. 👍

Sent from my iPhone

On Nov 6, 2016, at 4:30 PM, Gunay Mert Karadogan notifications@github.com wrote:

Hey @codeOfRobin Thank you for this PR. I came here to merge this. However, this is doing much more than porting it to Swift 3. The example looks a lot different. It fails when I write some text, and delete it.

I can add you as a maintainer, but you should keep the library simple, and clear from your company's needs like changing the default domain, color, or adding a method like chalJaBC (not sure why we need this).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gmertk / ParkedTextField

Ported to Swift 3. Tests have passed 🎉 #19